fix(core): enhanced contrast when UserMenuItem is focused #42643
Conversation
emoral435
requested review from
JuliaKirschenheuter,
Pytal,
ShGKme and
szaimen
There was a problem hiding this comment.
The problem here is that we have a conflict between .active and :focus-visible styles.
This solution fixes it by manually defining .active:focus-visible styles. But it is more risky as we need to manually manage consistency between all 3 cases. For example, icon is not light on dark mode now:
As alternative, we can disable active styles from focus visible by adding :not(:focus-visible) selector on active styles (on both a and img. For some reason it's 2 blocks, but we can do it in 1)
Then we won't need to duplicate styles and can be sure that they are the same.
|
@ShGKme your suggestion worked perfectly :) thank you! This is the proposed changes outcome:
|
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
emoral435
force-pushed
the
fix/core/42565/focus-for-user-menu-is-not-accessible
branch
from
de1747a to
d0d5013
Compare
|
/backport to stable28 |
emoral435
deleted the
fix/core/42565/focus-for-user-menu-is-not-accessible
branch
|
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Summary
Makes the focus and active state of the user-menu for the chosen view have better contrast
🖼️ Screenshots
Checklist